Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor yaml structure and test invocation #2153

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Refactor yaml structure and test invocation #2153

wants to merge 5 commits into from

Conversation

hallipr
Copy link
Member

@hallipr hallipr commented Feb 13, 2025 •
edited
Loading

  • Remove the partial job / partial step template of ci.yml in favor of major job templates and only shared step templates
  • Remove the test job -> build job dependency so tests start faster
  • Remove the UnitTest and Functional test parameters to the test job and script

addresses #2070

@hallipr hallipr force-pushed the users/pahallis/faster-test branch from 0fc6340 to ae40fea Compare February 13, 2025 22:43
@hallipr hallipr marked this pull request as ready for review February 13, 2025 23:18
@hallipr hallipr marked this pull request as draft February 13, 2025 23:18
@hallipr hallipr force-pushed the users/pahallis/faster-test branch from d7c78fe to d874422 Compare February 13, 2025 23:22
@hallipr hallipr force-pushed the users/pahallis/faster-test branch from d874422 to e5c12d2 Compare February 13, 2025 23:45
@hallipr hallipr changed the title Fan out to test legs faster Refactor yaml structure and test invocation Feb 13, 2025
@hallipr hallipr marked this pull request as ready for review February 14, 2025 19:02
heaths
heaths reviewed Feb 14, 2025
View reviewed changes
eng/scripts/Test-Packages.ps1
Comment on lines +60 to +63
Invoke-LoggedCommand "cargo +$Toolchain test --doc --no-fail-fast" -GroupOutput
Write-Host "`n`n"

Invoke-LoggedCommand "cargo +$Toolchain test --doc --no-fail-fast"
Invoke-LoggedCommand "cargo +$Toolchain test --all-targets --no-fail-fast" -GroupOutput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add --all-features as well.

/cc @analogrelay

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add --all-features to both calls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths left review comments

@RickWinter RickWinter RickWinter left review comments

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hallipr @heaths @RickWinter