Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_command abstraction to azure_identity #2175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arpad-m
Copy link
Contributor

@arpad-m arpad-m commented Feb 14, 2025

Adds a run_command function to azure_identity and uses it in the one place where we used async-process before. We provide two implementations:

  • one based on tokio, behind an optional feature
  • the other (used by default) is a manual implementation with a oneshot channel and a dedicated thread

successor of #1654
fixes #1652

@github-actions github-actions bot added Azure.Identity The azure_identity crate Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Feb 14, 2025
Copy link

Thank you for your contribution @arpad-m! We will review the pull request and get back to you soon.

@arpad-m
Copy link
Contributor Author

arpad-m commented Feb 14, 2025

Note that I have not tested the patch, but the implementation seems pretty straightforward to me.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

While this does solve the problem, it does not align with our design of providing a means of abstraction to callers e.g., implementing a trait to run on their own async runtime like our HttpClient. That is more what I had in mind when I opened #2002 (more about file IO , but I meant to do async child process forks as well).

We'd certainly be happy to review work more aligned with that. It should go in azure_core in, perhaps, a module named process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity The azure_identity crate Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

async-io transitive dependency
2 participants