Redefine Method, StatusCode from http_types in typespec#2331
Merged
heaths merged 4 commits intoAzure:mainfrom Mar 14, 2025
Merged
Redefine Method, StatusCode from http_types in typespec#2331heaths merged 4 commits intoAzure:mainfrom
heaths merged 4 commits intoAzure:mainfrom
Conversation
Resolves Azure#1644 and replaces Azure#2233. The latter PR was a good attempt but we decided internally we don't want to take a dependency on a different crate - `http` ; though, we do have a transitive dependency on it already - for something so simple. This starts as a copy from http_types with appropriate attribution. We may want to remove a bunch of Methods we don't need, though, at some point.
heaths
commented
Mar 14, 2025
heaths
requested review from
FabianMeiswinkel,
Pilchie,
analogrelay,
kirankumarkolli,
kundadebdatta and
tvaron3
as code owners
LarryOsterman
previously approved these changes
Mar 14, 2025
heaths
dismissed
LarryOsterman’s stale review
I don't think this is the right course of action for Method. It's a request-only model so I don't think we need to make it an extensible enum which, because String doesn't implement Copy, means we have to clone() it everywhere.
I want to discuss this more.
LarryOsterman
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1644 and replaces #2233. The latter PR was a good attempt but we decided internally we don't want to take a dependency on a different crate -
http; though, we do have a transitive dependency on it already - for something so simple.This starts as a copy from http_types with appropriate attribution. We may want to remove a bunch of Methods we don't need, though, at some point.