Draft
Conversation
| /// directly into non-overlapping buffer sub-slices via unsafe `SendSlice`. | ||
| /// | ||
| /// Returns the number of bytes written to the buffer. | ||
| pub async fn reqwest_download_to( |
Member
There was a problem hiding this comment.
If this isn't just an experiment, then you probably need to condition this on a "reqwest" feature flag.
| serde.workspace = true | ||
| serde_json.workspace = true | ||
| time.workspace = true | ||
| tokio = { workspace = true, features = ["rt", "sync"] } |
Member
There was a problem hiding this comment.
Tokio dependencies need to be under a feature flag so first party customers can use them.
You can also use the customer configured runtime if you need to (azure_core::get_async_runtime()).
| futures.workspace = true | ||
| percent-encoding.workspace = true | ||
| pin-project.workspace = true | ||
| reqwest.workspace = true |
Member
There was a problem hiding this comment.
This needs to be conditional on a feature, see the reqwest feature in azure_core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.