Skip to content

Fix spec errors in PARTITION_LEVEL_FAILOVER_SPEC.md#3919

Draft
Copilot wants to merge 6 commits intorelease/azure_data_cosmos-previewsfrom
copilot/sub-pr-3880-again
Draft

Fix spec errors in PARTITION_LEVEL_FAILOVER_SPEC.md#3919
Copilot wants to merge 6 commits intorelease/azure_data_cosmos-previewsfrom
copilot/sub-pr-3880-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 11, 2026

Five correctness and accuracy issues in the partition-level failover spec, flagged during review of #3880.

Changes

  • Wrong substatus code: 404 | 1022 (ReadSessionNotAvailable)404 | 1002. Substatus 1022 is LeaseNotFound; 1002 is the correct code for ReadSessionNotAvailable.
  • PartitionKeyRange equality semantics: Spec claimed equality/hashing used only id; actual implementation uses all four fields. Added resource_id to the struct definition and updated the description accordingly.
  • Misleading PPCB flag description: Replaced "Master switch — when false, PPCB is disabled entirely" with an accurate description of the server_flag || env_var logic. The env var is a fallback, not a master switch.
  • Overstated failback scope: "scans all failed-over partitions" → "scans all circuit-breaker failed-over partitions" to reflect that the failback loop only iterates the PPCB map, not the PPAF map.
  • Broken cross-reference: Fixed relative path to TRANSPORT_PIPELINE_SPEC.md../../azure_data_cosmos_driver/docs/TRANSPORT_PIPELINE_SPEC.md.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ailback scope, broken link

Co-authored-by: FabianMeiswinkel <[email protected]>
Copilot AI changed the title [WIP] Fix substatus code and equality semantics in Cosmos specs Fix spec errors in PARTITION_LEVEL_FAILOVER_SPEC.md Mar 11, 2026
Base automatically changed from users/kundadebdatta/add_ppaf_spec_for_driver to release/azure_data_cosmos-previews March 16, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants