Add more supported property formats #4676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr and
babbageclunk
as code owners
github-project-automation
bot
moved this to In Progress
in Azure Service Operator Roadmap
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- v2/api/kubernetesconfiguration/v1api20241101/structure.txt: Language not supported
- v2/api/machinelearningservices/v1api20240401/structure.txt: Language not supported
- v2/api/managedidentity/v1api20220131preview/structure.txt: Language not supported
- v2/api/managedidentity/v1api20230131/structure.txt: Language not supported
matthchr
reviewed
Apr 18, 2025
theunrepentantgeek
force-pushed
the
feature/improve-formats
branch
from
a633aff to
630d276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds validation for new data formats, improving our validation for some properties.
New formats are:
The format
bytestill remains ignored as it's unclear what regex should be used.Prerequisite: #4675
How does this PR make you feel?