Add client invocation for RestHublifetimeManager #2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Sindo
reviewed
Jul 28, 2025
src/Microsoft.Azure.SignalR.Management/RestHubLifetimeManager.cs
Outdated
Show resolved
Hide resolved
|
Don't forget to add e2e tests in |
|
@Y-Sindo E2E should wait for next release after the RT fixed is deployed right? After discussion will add it |
Y-Sindo
reviewed
Aug 21, 2025
src/Microsoft.Azure.SignalR.Management/RestHubLifetimeManager.cs
Outdated
Show resolved
Hide resolved
Y-Sindo
reviewed
Aug 26, 2025
| args, | ||
| async response => | ||
| { | ||
| responseContent = await response.Content.ReadAsStringAsync(cancellationToken); |
There was a problem hiding this comment.
Use DeserializeAsync here directly
There was a problem hiding this comment.
And RestClient already contains an ObjectSerializer, you can reuse that one.
There was a problem hiding this comment.
Updated by exposing the ObjectSerializer in the RestClient and using that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)