Patch for destination length check with no read permissions

Azure · Oct 25, 2023 · b09722e · b09722e
1 parent a756368
commit b09722e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,6 +1,12 @@
 
 # Change Log
 
+## Version 10.21.1
+
+### Bug Fixes
+
+1. Fixed an issue where validating destination length would fail a job instead of logging the error if read permissions are not provided.
+
 ## Version 10.21.0
 
 ### New Features

diff --git a/common/version.go b/common/version.go
@@ -1,6 +1,6 @@
 package common
 
-const AzcopyVersion = "10.21.0"
+const AzcopyVersion = "10.21.1"
 const UserAgent = "AzCopy/" + AzcopyVersion
 const S3ImportUserAgent = "S3Import " + UserAgent
 const GCPImportUserAgent = "GCPImport " + UserAgent

diff --git a/ste/xfer-anyToRemote-file.go b/ste/xfer-anyToRemote-file.go
@@ -25,6 +25,7 @@ import (
 	"crypto/md5"
 	"errors"
 	"fmt"
+	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
 	"github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/blob"
 	"hash"
 	"net/http"
@@ -552,8 +553,9 @@ func epilogueWithCleanupSendToRemote(jptm IJobPartTransferMgr, s sender, sip ISo
 		shouldCheckLength := true
 		destLength, err := s.GetDestinationLength()
 
-		if resp, respOk := err.(pipeline.Response); respOk && resp.Response() != nil &&
-			resp.Response().StatusCode == http.StatusForbidden {
+		var respErr *azcore.ResponseError
+		resp, respOk := err.(pipeline.Response)
+		if (respOk && resp.Response() != nil && resp.Response().StatusCode == http.StatusForbidden) || (errors.As(err, &respErr) && respErr.StatusCode == http.StatusForbidden) {
 			// The destination is write-only. Cannot verify length
 			shouldCheckLength = false
 			checkLengthFailureOnReadOnlyDst.Do(func() {