Create missing resources in sync, allow blob to overlap #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
gapra-msft
reviewed
Dec 17, 2024
gapra-msft
reviewed
Dec 17, 2024
gapra-msft
reviewed
Jan 13, 2025
gapra-msft
reviewed
Jan 13, 2025
gapra-msft
reviewed
Jan 13, 2025
gapra-msft
reviewed
Jan 13, 2025
Creates parity with accidental functionality of blob, extends functionality on FNS
adreed-msft
force-pushed
the
adreed/create-resources-allow-blob-overlap
branch
from
4fa0826 to
a0c692f
Compare
…ob-overlap' into adreed/create-resources-allow-blob-overlap
vibhansa-msft
approved these changes
Jan 22, 2025
adreed-msft
force-pushed
the
adreed/create-resources-allow-blob-overlap
branch
from
78e1676 to
b134210
Compare
gapra-msft
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates parity with accidental functionality of blob, extends functionality on FNS
Description
As it stands, when using a Blob destination, AzCopy is capable of creating a file if it is missing, as well as a directory if it is missing. However, if a directory stub exists, sync does not allow it to be overwritten, or overlapped, if using trailing slash directory stubs (e.g.
foo/).In addition, this PR extends the resource creation functionality to containers, shares, and filesystems.
Feature / Bug Fix: Fleshing out the result of undefined behavior with Sync, creating parity with other destination resources.
Related Links:
Email Subject
Re: SciClone/AzCopy issues summary and resolution planADO
#30057272Type of Change
How Has This Been Tested?
Both sides of the feature, blob overlapping and resource creation, are exhaustively tested with two new E2E tests, covering their relevant scenarios.