Backward compatibility with older az accounts with AsSecureString #3191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonwuakpa-msft
requested review from
gapra-msft,
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds backward compatibility support for older versions of Azure PowerShell accounts (specifically versions prior to Az.Accounts 5.0.0) by handling the absence of the -AsSecureString parameter in the Get-AzAccessToken command.
- Adds retry logic to fall back to the older command format when
-AsSecureStringparameter is not supported - Implements error detection for the specific parameter mismatch error
- Modifies the PowerShell command construction to support both old and new Az.Accounts versions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Type of Change
How Has This Been Tested?
Manually tested. I downgraded to an old Az.Account version 2.2.0, confirmed the error about AsSecureString was returned. Implemented the changes in this PR and validated
login --login-type="pscred"works.Thank you for your contribution to AzCopy!