LCM refactor #3202
Open
LCM refactor #3202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft and
wonwuakpa-msft
as code owners
| common.NewAzError(common.EAzError.LoginCredMissing(), "No SAS token or OAuth token is present and the resource is not public") | ||
| if public { | ||
| credType = common.ECredentialType.Anonymous() | ||
| public = true |
There was a problem hiding this comment.
Since we are already inside 'if public', the variable is guaranteed to be true.
Reassigning public = true here isnt redundant?
| @@ -0,0 +1,732 @@ | |||
| package cmd | |||
| closeFunc func() // used to close logs before exiting | ||
| waitForUserResponse chan bool | ||
| msgHandlerChannel chan *common.LCMMsg | ||
| OutputVerbosityType common.OutputVerbosity |
There was a problem hiding this comment.
Should we keep this local variable? As we have SetOutputVerbosity() API exposed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry in advance for how large this PR is.
This PR does two things