Added supoprt for jobs resume progress tracking in library #3203
Conversation
gapra-msft
requested review from
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft and
wonwuakpa-msft
as code owners
| return r.jobID | ||
| } | ||
|
|
||
| func (r *resumeProgressTracker) GetElapsedTime() time.Duration { |
There was a problem hiding this comment.
TODO: I should probably keep a variable for elapsed time that gets set once jobDone is true in CheckProgress. That way Elapsed time is a true measure of when the job ended.
| @@ -0,0 +1,233 @@ | |||
| package azcopy | |||
| } | ||
| } | ||
|
|
||
| // TODO : rename interface method to OnError to match other methods |
There was a problem hiding this comment.
This todo is not critical right now, and I want to limit changes to files - so we can do this after sync and copy are done
| j.handler.Info("Cancellation requested. Beginning clean shutdown...") | ||
| if !reporter.CompletedEnumeration() { | ||
| answer := j.handler.Prompt("The enumeration (source only for copy, source/destination comparison for sync) is not complete, "+ | ||
| "cancelling the job at this point means it cannot be resumed.", |
There was a problem hiding this comment.
Should we mention jobID here?
| @@ -0,0 +1,12 @@ | |||
| package common | |||
| Number of Folder Transfers Skipped: %v | ||
| Total Number of Bytes Transferred: %v | ||
| Percent Complete (approx): %.1f | ||
| Final Job Status: %v |
There was a problem hiding this comment.
Thought: We are currently repeating the string line:445-458 across multiple jobs. Instead of duplicating it, can we define it once as a variable and reuse it wherever needed?
There was a problem hiding this comment.
I'll add an item to clean up this code for after the library refactor
Use new job progress tracking logic. Copy and sync will also move to using this progress tracker eventually, so we can remove it from the glcm code.
See this for design of job lifecycle manager
https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/846803/JobLifecycleManager