Redact x-ams-credential from logs #3206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonwuakpa-msft
requested review from
gapra-msft,
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds redaction of the x-amz-credential parameter from logs to prevent sensitive AWS credential information from being exposed in AzCopy logs.
- Adds
x-amz-credentialconstant and redaction logic in URL sanitization - Updates log sanitizer to include "credential" as a sensitive query parameter
- Adds test case to verify AWS credential redaction functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| common/extensions.go | Adds constant for x-amz-credential and implements redaction logic in URL sanitization |
| common/logSanitizer.go | Adds "credential" to the list of sensitive query string keys for log redaction |
| common/zt_logSanitizer_test.go | Adds test case to verify x-amz-credential redaction works correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gapra-msft
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
[ADO Item] (https://msazure.visualstudio.com/One/_workitems/edit/33827187/)
[IcM] (https://portal.microsofticm.com/imp/v5/incidents/details/656441254/summary)
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!