Introduce FileSMB for non File s2s or upload/download paths #3211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphulkar-msft
requested review from
gapra-msft,
adreed-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft and
wonwuakpa-msft
as code owners
gapra-msft
reviewed
Sep 10, 2025
gapra-msft
reviewed
Sep 10, 2025
wonwuakpa-msft
approved these changes
Sep 11, 2025
gapra-msft
reviewed
Sep 11, 2025
| } | ||
|
|
||
| // We can ignore the error if we fail to get the share properties. | ||
| shareProtocol, _ := getShareProtocolType(ctx, serviceClient, resource, protocol) | ||
|
|
||
| if shareProtocol == common.ELocation.File() { | ||
| if isSource && fromTo.From() != common.ELocation.File() { | ||
| return fmt.Errorf("The %s share has SMB protocol enabled. To copy %s a SMB share, use the appropriate --from-to flag value", direction, direction) | ||
| return fmt.Errorf("The %s share has SMB protocol enabled. "+ |
There was a problem hiding this comment.
can't you just use the appropriate string in the error message here? Checking is Source above and here seems redundant
gapra-msft
reviewed
Sep 11, 2025
| } | ||
|
|
||
| // We can ignore the error if we fail to get the share properties. | ||
| shareProtocol, _ := getShareProtocolType(ctx, serviceClient, resource, protocol) | ||
|
|
||
| if shareProtocol == common.ELocation.File() { | ||
| if isSource && fromTo.From() != common.ELocation.File() { | ||
| return fmt.Errorf("The %s share has SMB protocol enabled. To copy %s a SMB share, use the appropriate --from-to flag value", direction, direction) | ||
| return fmt.Errorf("The %s share has SMB protocol enabled. "+ |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("The %s share has SMB protocol enabled. "+ | |
| return errors.New("The source share has SMB protocol enabled. "+ |
gapra-msft
reviewed
Sep 11, 2025
| } | ||
|
|
||
| // We can ignore the error if we fail to get the share properties. | ||
| shareProtocol, _ := getShareProtocolType(ctx, serviceClient, resource, protocol) | ||
|
|
||
| if shareProtocol == common.ELocation.File() { | ||
| if isSource && fromTo.From() != common.ELocation.File() { | ||
| return fmt.Errorf("The %s share has SMB protocol enabled. To copy %s a SMB share, use the appropriate --from-to flag value", direction, direction) | ||
| return fmt.Errorf("The %s share has SMB protocol enabled. "+ | ||
| "To copy %s a SMB share, use the appropriate --from-to flag value", location, direction) |
There was a problem hiding this comment.
Suggested change
| "To copy %s a SMB share, use the appropriate --from-to flag value", location, direction) | |
| "To copy from a SMB share, use the appropriate --from-to flag value") |
gapra-msft
reviewed
Sep 11, 2025
| } | ||
| if !isSource && fromTo.To() != common.ELocation.File() { | ||
| return fmt.Errorf("The %s share has SMB protocol enabled. To copy %s a SMB share, use the appropriate --from-to flag value", direction, direction) | ||
| return fmt.Errorf("The %s share has NFS protocol enabled. "+ |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("The %s share has NFS protocol enabled. "+ | |
| return errors.New("The destination share has NFS protocol enabled. "+ |
gapra-msft
reviewed
Sep 11, 2025
| } | ||
| if !isSource && fromTo.To() != common.ELocation.File() { | ||
| return fmt.Errorf("The %s share has SMB protocol enabled. To copy %s a SMB share, use the appropriate --from-to flag value", direction, direction) | ||
| return fmt.Errorf("The %s share has NFS protocol enabled. "+ | ||
| "To copy %s a NFS share, use the appropriate --from-to flag value", location, direction) |
There was a problem hiding this comment.
Suggested change
| "To copy %s a NFS share, use the appropriate --from-to flag value", location, direction) | |
| "To copy to a NFS share, use the appropriate --from-to flag value") |
gapra-msft
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
UT added
Thank you for your contribution to AzCopy!