Fix nil pointer panic when using MD5 hash comparison on FAT32/exFAT drives #3225
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an immediate runtime panic that occurs when using the
--compare-hash=MD5flag with sync operations on FAT32/exFAT formatted drives on Windows.Problem
When running commands like:
On FAT32/exFAT drives, users encountered an immediate panic:
Root Cause
The issue occurred because:
zc_enumerator.goline 463, the error fromnewLocalTraverser()was being ignored usingoutput, _ = newLocalTraverser(...)IsDirectory()was called later in the sync processSolution
The fix is minimal and surgical - properly handle the error from
newLocalTraverser()instead of ignoring it:Before:
After:
Impact
This change allows users to receive proper feedback about filesystem compatibility issues rather than experiencing unexpected crashes, enabling them to use alternative hash storage modes or different filesystems as needed.
Fixes #3221.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fake.blob.core.windows.net./azcopy/azure-storage-azcopy sync /tmp/hash_init_test_1758259955 REDACTED --compare-hash=MD5 --dry-run(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.