Format files according to goimports #3254
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the sake of curiosity, since there was no
.golangci-lint.yamlfile in the project, I experimented with a simple configuration file locally, and have found a bunch of issues. Sorting the imports according to goimports is good practice, so stdlib golang libraries are in the top, and then dependencies from external sources below that.Note that the command has also fixed formatting of fields in structs, which is another Golang best practice.
If it is of interest, I can volunteer to fix some of the other ones, and introduce a proper linting configuration.
The command also added lines in the top of files, e.g.,
//go:build linux || darwinwhenever there was a// +build linux(or darwin). I just let it be.I have used:
VSCode with Golang configuration automatically sorts the imports when you save the file.
Type of Change
How Has This Been Tested?
Just with compilation. Logic shouldn't be affected by reformatting.
Thank you for your contribution to AzCopy!