Introduce skip value support for --hardlinks flag #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphulkar-msft
requested review from
adreed-msft,
gapra-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft,
vibhansa-msft and
wonwuakpa-msft
as code owners
* root props init functionality * add test * WIP * added creating stored object for blob root folders * init * init * init * testing * tests * changed return type * clean ups * cleanups * removed preserve-root-props flag * minor comments * remove macOs perservePerm testing * fix xAttr issue in ADO pipeline --------- Co-authored-by: Gauri Lamunion <[email protected]>
adreed-msft
approved these changes
Oct 16, 2025
|
|
||
| // OS check: hardlinks handling only supported on Linux in case of upload and download | ||
| if runtime.GOOS != "linux" && !fromTo.IsS2S() { | ||
| return fmt.Errorf("The --hardlinks option is only supported on Linux.") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("The --hardlinks option is only supported on Linux.") | |
| return fmt.Errorf("For uploads and downloads, the --hardlinks option is only supported on Linux.") |
* initial traverser refactor * Fix missed export * Migrated UT * Fix account traversers * Move token manager to the client * remove credential op options and credential info from ste that was unused * Suggestions from copilot * Copilot comment * add copyright * standardize error handling * move lcm functionality to cmd folder * Cpk may not be set for e2e tests * using wrong cpk methods * Fix tests and build * fixed build for runner * fix npe * add ui hooks * remove unused var * try to fix flaky test
* root props init functionality * add test * WIP * added creating stored object for blob root folders * init * init * init * testing * tests * changed return type * clean ups * cleanups * removed preserve-root-props flag * minor comments * remove macOs perservePerm testing * fix xAttr issue in ADO pipeline * fix typos * 2 retries to get access token * 1s time diff * dstObj creation --------- Co-authored-by: Gauri Lamunion <[email protected]>
…into dphulkar/hardlinkSupport-1
…into dphulkar/hardlinkSupport-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://microsoft.sharepoint.com/:w:/t/AzureFiles/EagOwYP1mypBg91t6cU1LVEBklb4bmNXesgm_aiPCQwqUA?e=VP6fVF
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
E2E Tests
Thank you for your contribution to AzCopy!