Skip to content

Moved LCM to cmd folder #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Moved LCM to cmd folder #3262

wants to merge 24 commits into from

Conversation

gapra-msft
Copy link
Member

@gapra-msft gapra-msft commented Oct 16, 2025 •
edited
Loading

This PR

  1. Moves LCM to cmd folder since its CLI specific functionality.
  2. Removes the LCM wrapper and replaces it with a call to log in copy/sync/resume
  3. Error handler is now injected to JobMgr

gapra-msft and others added 21 commits October 9, 2025 08:41
@gapra-msft
initial traverser refactor
374cf53
@gapra-msft
Fix missed export
724aa93
@gapra-msft
Migrated UT
6f616fb
@gapra-msft
Fix account traversers
32203b5
@gapra-msft
Move token manager to the client
e80adc1
@gapra-msft
remove credential op options and credential info from ste that was un…
f2195f5 
…used
@gapra-msft
Suggestions from copilot
21c3036
@gapra-msft
Merge branch 'main' into gapra/traverserCodeReorg
2d86689
@gapra-msft
Merge branch 'gapra/traverserCodeReorg' into gapra/credentialCodeReorg
33c03ca
@gapra-msft
Copilot comment
45129cb
@gapra-msft
Merge branch 'main' into gapra/credentialCodeReorg
5101cfc
@gapra-msft
add copyright
dd612e6
@gapra-msft
standardize error handling
06b8798
@gapra-msft
move lcm functionality to cmd folder
cd2e794
@gapra-msft
Cpk may not be set for e2e tests
179dc47
@gapra-msft
using wrong cpk methods
2fedb62
@gapra-msft
Merge branch 'gapra/standardizeErrors' into gapra/lcmRefactor
e4e0ff2
@gapra-msft
Merge branch 'main' into gapra/credentialCodeReorg
416b7ac
@gapra-msft
Fix tests and build
88f67b5
@gapra-msft
fixed build for runner
1a05425
@gapra-msft
fix npe
f45af0e
Base automatically changed from gapra/credentialCodeReorg to main October 17, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adreed-msft adreed-msft Awaiting requested review from adreed-msft adreed-msft is a code owner

@dphulkar-msft dphulkar-msft Awaiting requested review from dphulkar-msft dphulkar-msft is a code owner

@vibhansa-msft vibhansa-msft Awaiting requested review from vibhansa-msft vibhansa-msft is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@souravgupta-msft souravgupta-msft Awaiting requested review from souravgupta-msft souravgupta-msft is a code owner

@tanyasethi-msft tanyasethi-msft Awaiting requested review from tanyasethi-msft tanyasethi-msft is a code owner

@wonwuakpa-msft wonwuakpa-msft Awaiting requested review from wonwuakpa-msft wonwuakpa-msft is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gapra-msft