Cleanup before sync migration #3292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
adreed-msft,
dphulkar-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft,
vibhansa-msft and
wonwuakpa-msft
as code owners
wonwuakpa-msft
previously approved these changes
Nov 18, 2025
gapra-msft
dismissed
wonwuakpa-msft’s stale review
The base branch was changed.
wonwuakpa-msft
approved these changes
Nov 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs code refactoring to reorganize validation, utility, and path handling code in preparation for sync command migration. The changes focus on extracting shared functionality into a new azcopy package to reduce code duplication and improve maintainability.
Key changes include:
- Moving validation functions (FromTo inference, NFS/SMB validation, MD5 validation) from
cmdtoazcopypackage - Extracting location level and path utilities to the
azcopypackage - Refactoring traverser initialization to use
ClientandCredentialTypedirectly instead ofCredentialInfowrapper - Consolidating dry-run logic into a dedicated processor file
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/validators.go | Removed validation functions that were moved to azcopy package |
| cmd/pathUtils.go | Removed LocationLevel and DetermineLocationLevel functions, moved to azcopy package |
| cmd/constants.go | Removed constants moved to azcopy package |
| azcopy/validationUtil.go | New file containing all validation logic extracted from cmd |
| azcopy/pathUtils.go | New file with path and location level utilities |
| azcopy/optionsUtil.go | New file with BlockSizeInBytes utility function |
| azcopy/remoteClientUtils.go | New file with service client creation utilities |
| cmd/dryrun_processor.go | New file consolidating dry-run processing logic |
| cmd/syncEnumerator.go | Updated to use new client creation approach and moved dry-run deletion setup |
| cmd/syncProcessor.go | Refactored to use new dry-run processor pattern |
| cmd/zc_processor.go | Removed dry-run logic moved to dedicated file |
| traverser/* | Updated to accept Client/CredentialType instead of CredentialInfo |
| e2etest/* | Updated imports from cmd to azcopy package for LocationLevel |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 50 out of 50 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup before migrating the sync command.
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Covered by existing tests
Thank you for your contribution to AzCopy!