Allow copies with leading slash or no name virtual dirs #3294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonwuakpa-msft
changed the title
//blob
wonwuakpa-msft
changed the title
//blob
wonwuakpa-msft
requested review from
adreed-msft,
dphulkar-msft and
gapra-msft
as code owners
wonwuakpa-msft
requested review from
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft and
vibhansa-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes silent failures when copying from unnamed virtual directories or blobs with leading slashes (e.g., //blob). Previously, AzCopy would normalize these paths causing 404 errors that were silently ignored. The fix adds proper error detection and reporting.
Key Changes:
- Added error handling in
listTraverser.Traverse()to catch and report FILE_NOT_FOUND errors - Implemented tracking of processed vs skipped items to return an error when nothing is successfully processed
- Added warning messages to inform users about leading slash issues in blob names
- Added comprehensive E2E tests covering various scenarios with unnamed directories and leading slashes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| traverser/zc_traverser_list.go | Adds error handling for IsDirectory() calls and tracks processed/skipped items to avoid silent failures |
| e2etest/zt_newe2e_blob_test.go | Adds E2E tests for unnamed virtual directories and leading slash scenarios |
| cmd/copyUtil.go | Adds warning message when detecting leading slash patterns in blob URLs |
| cmd/copyEnumeratorInit.go | Minor formatting change (blank line addition) |
| cmd/copy.go | Typo fix in TODO comment: "preservePermissinos" → "preservePermissions" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adreed-msft
requested changes
Nov 21, 2025
wonwuakpa-msft
changed the title
gapra-msft
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles copies from un-named virtual directories or blob with leading slashes e.g
//blobFeature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
PBI Item
Team thread
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!