Skip to content

Conversation

@adreed-msft
Copy link
Member

Description

  • Feature / Bug Fix: Covers a couple additional errors we're seeing in an IcM

  • Related Links:

  • ICM 21000000787291

Type of Change

  • Bug fix
  • New feature
  • Documentation update required
  • Code quality improvement
  • Other (describe):

How Has This Been Tested?

Retry policy adapted

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the retry policy to handle additional network errors encountered in production incidents. The changes add OS-agnostic error detection for common network failures that should trigger retries.

  • Adds retry logic for io.ErrUnexpectedEOF, io.EOF, and net.ErrClosed errors
  • Includes comprehensive test coverage for the new error conditions
  • Reorganizes imports following Go conventions (stdlib separated from third-party packages)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ste/xferRetryHelper.go Adds error checks for common network errors (io.ErrUnexpectedEOF, io.EOF, net.ErrClosed) to the retry policy and organizes imports
ste/xferRetryHelper_test.go Adds test cases to verify the new network errors trigger retries as expected and organizes imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants