Progress and result summary logging to happen in library #3315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
adreed-msft,
dphulkar-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft,
vibhansa-msft and
wonwuakpa-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors progress and result summary logging by moving formatting logic from the CLI command layer (cmd/) into the azcopy library layer. This allows the library to handle logging internally, reducing code duplication and improving separation of concerns.
Key Changes
- Moved progress and result formatting functions from
cmd/to a newazcopy/output.gofile - Renamed interfaces for clarity:
CopyJobHandler→CopyHandler,SyncJobHandler→SyncHandler,CopyJobProgress→CopyProgress,SyncJobProgress→SyncProgress - Added logging calls within the library's progress trackers so that progress is logged automatically without requiring the CLI layer to do it
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| azcopy/output.go | New file containing all formatting functions for progress and result output (GetCopyProgress, GetCopyResult, GetSyncProgress, GetSyncResult, and utility functions) |
| azcopy/copy.go | Updated interface names, added internal logging call for copy results, and added job cleanup |
| azcopy/sync.go | Updated interface names, added internal logging call for sync results, and added job cleanup |
| azcopy/transferProgressTracker.go | Updated interface reference and added internal logging of progress |
| azcopy/syncProgressTracker.go | Updated interface reference and added internal logging of progress |
| azcopy/jobsResume.go | Added internal logging of progress, updated function signature formatting |
| cmd/copy.go | Removed duplicate formatting functions, updated to use library functions from azcopy package, removed unused imports |
| cmd/sync.go | Removed duplicate formatting functions, updated to use library functions from azcopy package, removed unused imports |
| cmd/jobsResume.go | Updated to use library functions from azcopy package, removed unused imports |
| jobsAdmin/init.go | Removed ToFixed and round utility functions (moved to azcopy/output.go) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.