Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ListBlob for hns accounts #1555

Open
wants to merge 37 commits into
base: blobfuse/2.4.1
Choose a base branch
from
Open

Conversation

ashruti-msft
Copy link
Collaborator

@ashruti-msft ashruti-msft commented Nov 4, 2024

✅ What

Using listblob api for listing for datalake accounts as in one call we get all the properties especially owner, group, permissions, resource type.

🤔 Why

It will decrease the calls made in the previous case which was list + getproperties call to now one list call

👩‍🔬 How to validate if applicable

Properties for directories received
Screenshot 2024-11-27 122316
Screenshot 2024-11-27 122331

Screenshot 2024-11-27 122339
Screenshot 2024-11-27 122808

@ashruti-msft ashruti-msft marked this pull request as ready for review November 27, 2024 10:43
component/azstorage/block_blob.go Outdated Show resolved Hide resolved
component/azstorage/block_blob.go Outdated Show resolved Hide resolved
component/azstorage/block_blob.go Outdated Show resolved Hide resolved
@jainakanksha-msft
Copy link
Collaborator

@ashruti-msft Please add unit testing,

@jainakanksha-msft
Copy link
Collaborator

@ashruti-msft As we will use blobfuse for Datalake,

// This is different from ADLS Gen2 behavior.

Do we have to consider this comment for any check?

@vibhansa-msft vibhansa-msft changed the base branch from main to blobfuse/2.4.1 November 29, 2024 08:00
@ashruti-msft
Copy link
Collaborator Author

@ashruti-msft As we will use blobfuse for Datalake,

// This is different from ADLS Gen2 behavior.

Do we have to consider this comment for any check?

No the behaviour described by this comment remains the same. Its related to getting atttributes for directories in FNs and HNs accounts. For FNS accounts while doing getattr we call the list function instead of getProperties to support virtual dir with no marker blob. For virtual dir with no makrer blob getproperties would have failed with 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants