Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deployment creation parameters #3405

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update deployment creation parameters #3405

wants to merge 2 commits into from

Conversation

dem108
Copy link
Contributor

@dem108 dem108 commented Oct 4, 2024

Description

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@dem108
Copy link
Contributor Author

dem108 commented Oct 4, 2024

@msakande this is regarding user story 320905. please approve. "cli-scripts-deploy-rest" flow above passed successfully. "bootstrapping-infra" seems to have an issue but it's not related to this change so can be ignored.

msakande
msakande approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@msakande msakande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs approval - these changes will not break our build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msakande msakande msakande approved these changes

@sdgilley sdgilley Awaiting requested review from sdgilley sdgilley is a code owner

@Blackmist Blackmist Awaiting requested review from Blackmist Blackmist is a code owner

@ssalgadodev ssalgadodev Awaiting requested review from ssalgadodev ssalgadodev is a code owner

@lgayhardt lgayhardt Awaiting requested review from lgayhardt lgayhardt is a code owner

@fbsolo-ms1 fbsolo-ms1 Awaiting requested review from fbsolo-ms1 fbsolo-ms1 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dem108 @msakande