fix: res/insights/private-link-scope deploys private endpoints in the subnet resource group
#4132
+659
−614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
Comment on lines
+368
to
+371
| @description('Required. List of exclusions that override the default access mode settings for specific private endpoint connections. Exclusions for the current created Private endpoints can only be applied post initial provisioning.') | ||
| exclusions: { | ||
| @description('Required. The private endpoint connection name associated to the private endpoint on which we want to apply the specific access mode settings.') | ||
| privateEndpointConnectionName: string | ||
| @description('Optional. The private endpoint connection name associated to the private endpoint on which we want to apply the specific access mode settings.') | ||
| privateEndpointConnectionName: string? |
There was a problem hiding this comment.
Why did both change the state?
Comment on lines
+380
to
+383
| @description('Required. Specifies the default access mode of ingestion through associated private endpoints in scope. Default is "Open" if no private endpoints are configured and will be set to "PrivateOnly" if private endpoints are configured. Override default behaviour by explicitly providing a value.') | ||
| ingestionAccessMode: 'Open' | 'PrivateOnly' | ||
|
|
||
| @description('Optional. Specifies the default access mode of queries through associated private endpoints in scope. Default is "Open" if no private endpoints are configured and will be set to "PrivateOnly" if private endpoints are configured. Override default behaviour by explicitly providing a value.') | ||
| queryAccessMode: 'Open' | 'PrivateOnly'? | ||
| }? | ||
| @description('Required. Specifies the default access mode of queries through associated private endpoints in scope. Default is "Open" if no private endpoints are configured and will be set to "PrivateOnly" if private endpoints are configured. Override default behaviour by explicitly providing a value.') |
There was a problem hiding this comment.
Why did both change the state?
|
Hey @ReneHezser, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3835
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.