-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for Discrimintor-based variants to readme utility #4146
Open
AlexanderSehr
wants to merge
38
commits into
main
Choose a base branch
from
users/alsehr/4128_discriminator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
Maintainers need to triage still
label
Jan 12, 2025
AlexanderSehr
added
Needs: Core Team 🧞
This item needs the AVM Core Team to review it
Type: CI 🚀
This issue is related to the AVM CI
and removed
Needs: Triage 🔍
Maintainers need to triage still
labels
Jan 12, 2025
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
label
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs: Core Team 🧞
This item needs the AVM Core Team to review it
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Type: CI 🚀
This issue is related to the AVM CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set-ModuleReadMe
script would throw an exception during the generation, returning the error that would hit the Pester-Output which in turn would pollute the test results the GitHub-Output function then failed to interpret and publish. The fix essentially catches this exception and fails the test with a proper error message, pointing to the actual cause of the error (e.g., a parameter not having a description category specified). See screenshots at the buttom for a before-after comparison.Required module fixes
Closes #4128
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Appendix
Error before the fix
Error after the fix