Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deployment monitoring function #4205

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jan 17, 2025

Description

New function introduced by @mbrat2005 to monitor deployments and avoid the deployment to go straight to the 'retry' if Azure failed to send a response at some point during a deployment (e.g., in case of error messages like 'an internal error occurred'). In those cases, the deployment on the Azure-side is actually still on.

TODO

  • Additional testing
  • Check if -AsJob is really required / the monitoring could send a ping back to the pipeline log to see that the deployment is still on
  • Check if all variables are correctly assigned. See:
    • Deployment status for [a-r-ash-c-3nodeswitchless.defaults-t1-20250116T0901005815Z] and sub-operations on subscription are: provisioningStates: [] statusCodes: [] (ref) vs
    • Deployment status for [a-r-ash-c-2nodeswitched.defaults-t1-20250116T0901546186Z] and sub-operations on subscription are: provisioningStates: [Succeeded] statusCodes: [Created] (ref)

Pipeline Reference

Pipeline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jan 17, 2025

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@AlexanderSehr AlexanderSehr added the Type: CI 🚀 This issue is related to the AVM CI label Jan 21, 2025
@AlexanderSehr AlexanderSehr self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: CI 🚀 This issue is related to the AVM CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant