fix: Update `avm/ptn/lz/sub-vending` -- Bug fixes and improvements #4274

sebassem · 2025-01-23T13:21:06Z

Description

Update modules versions
Switch to private endpoints for the deployment script instead of service endpoints
Added PublicnetworkAccess:Disabled to the storage account due to a recent change in policy
Update CI pipeline to pin Az.Accounts and Az,Subscription modules' versions due to a recent bug
Update deployment script naming to avoid duplicate names

Pipeline Reference

Pipeline

Type of Change

Update to CI Environment or utilities (Non-module affecting changes)
Azure Verified Module updates:
- Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
  - Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
  - The bug was found by the module author, and no one has opened an issue to report it yet.
- Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
- Breaking changes and I have bumped the MAJOR version in version.json.
- Update to documentation

Checklist

I'm sure there are no other open Pull Requests for the same update/change
I have run Set-AVMModule locally to generate the supporting module files.
My corresponding pipelines / checks run clean and green without any errors or warnings

…nce README with new resource references

… deployment scripts

…t parameters

…script and update download commands to use Invoke-WebRequest

…d Microsoft repository GPG keys

…icep files

…/sebassem/bicep-registry-modules into avm-lz-subvending-policy-refresh

…nction

…al script

…ersion requirement

…ions

…port in action.yml

…n module import in action.yml

…module import in action.yml

…action.yml

…keys in Set-EnvironmentOnAgent.ps1

…/sebassem/bicep-registry-modules into avm-lz-subvending-policy-refresh

microsoft-github-policy-service · 2025-01-23T13:21:42Z

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

microsoft-github-policy-service · 2025-01-23T13:21:44Z

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

AlexanderSehr · 2025-01-24T16:08:20Z

.github/actions/templates/avm-setEnvironment/action.yml

@@ -74,4 +74,6 @@ runs:
        # Set agent up
        Set-EnvironmentOnAgent -PSModules $modules

+        #Import-module Az.Subscription -MinimumVersion 0.11.1


AlexanderSehr · 2025-01-26T08:44:48Z

utilities/pipelines/e2eValidation/resourceRemoval/helper/Invoke-ResourceRemoval.ps1

@@ -269,6 +269,7 @@ function Invoke-ResourceRemoval {
            if ($subscriptionState -eq 'Enabled') {
                Write-Verbose ('[*] Disabling resource [{0}] of type [{1}]' -f $subscriptionName, $Type) -Verbose
                if ($PSCmdlet.ShouldProcess("Subscription [$subscriptionName]", 'Remove')) {
+                    Import-Module Az.Accounts -MinimumVersion 4.0.1


Is this still required here?

Yes, it only worked when I specified this here, I can remove it once the agents use the latest version of this module by default

AlexanderSehr · 2025-01-26T08:46:22Z

.github/actions/templates/avm-setEnvironment/action.yml

@@ -45,7 +45,7 @@ runs:

        # Define PS modules to install on the runner
        $modules = @(
-            @{ Name = 'Az.Accounts' },
+            @{ Name = 'Az.Accounts'; Version = '4.0.2' },


Please add a comment here to explain why this version so if we ever want to allow any never version than 4.0.2 and retest we know which module this was for. The same applies to the other explicit version your hardcoded below.

sebassem added 30 commits January 22, 2025 11:03

feat: Update default values for deployment script parameters and enha…

bbcac97

…nce README with new resource references

fix: Update template hashes and downgrade Azure PowerShell version in…

b9f5bff

… deployment scripts

feat: Import necessary PowerShell modules and update deployment scrip…

c5ce8f6

…t parameters

feat: Reintroduce PowerShell module import in Set-EnvironmentOnAgent …

3ff8544

…script and update download commands to use Invoke-WebRequest

fix: Replace Invoke-WebRequest with curl for downloading Bicep CLI an…

ead9d19

…d Microsoft repository GPG keys

testing

1346f6f

test

ac2fef9

test

550a4b5

fix: Update deployment-script module version from 0.5.1 to 0.3.1 in B…

9a2d08b

…icep files

test

ec82f3a

test

d0e4321

fix: Update deployment-script module version from 0.3.1 to 0.2.3 in B…

4b2073b

…icep files

Merge branch 'avm-lz-subvending-policy-refresh' of https://github.com…

1f5e374

…/sebassem/bicep-registry-modules into avm-lz-subvending-policy-refresh

test

8592f1e

test

d8efdad

test

93300b3

test

1b8dafd

test

1b262dd

refactor: replace curl with Invoke-WebRequest for better compatibility

8ca2527

test

450c6be

fix: remove unnecessary continue statement in Install-CustomModule fu…

ed3cd60

…nction

fix: correct module import for disabling Azure subscription

74b290b

fix: specify minimum version for Az.Accounts module in resource remov…

f3d0f71

…al script

fix: update Az.Accounts module version to 4.0.2 and enforce minimum v…

e8cbf00

…ersion requirement

fix: comment out Az.Accounts module import in action.yml

9ee87d1

fix: update verbose output to correctly display installed module vers…

ce67e66

…ions

fix: replace Az.Accounts module import with Az.Subscription module im…

9b8c0bf

…port in action.yml

fix: remove Az.Accounts module import and replace with Az.Subscriptio…

d3ac4f8

…n module import in action.yml

fix: update Az.Subscription module version to 0.11.2 and comment out …

70a8684

…module import in action.yml

fix: ensure Az.Subscription module version is correctly specified in …

a2dcd5e

…action.yml

sebassem added 3 commits January 23, 2025 15:16

Merge branch 'Azure:main' into avm-lz-subvending-policy-refresh

bb5b7f1

fix: replace curl with wget for downloading Microsoft repository GPG …

5c42d35

…keys in Set-EnvironmentOnAgent.ps1

Merge branch 'avm-lz-subvending-policy-refresh' of https://github.com…

c0f23b8

…/sebassem/bicep-registry-modules into avm-lz-subvending-policy-refresh

sebassem requested review from a team as code owners January 23, 2025 13:21

avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jan 23, 2025

microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jan 23, 2025

microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jan 23, 2025

sebassem changed the title ~~Fix: Sub-vending bug fixes and improvements~~ fix: Sub-vending bug fixes and improvements Jan 23, 2025

AlexanderSehr reviewed Jan 24, 2025

View reviewed changes

eriqua changed the title ~~fix: Sub-vending bug fixes and improvements~~ fix: Update avm/ptn/lz/sub-vending -- Bug fixes and improvements Jan 26, 2025

eriqua added Class: Pattern Module 📦 This is a pattern module Type: CI 🚀 This issue is related to the AVM CI and removed Needs: Triage 🔍 Maintainers need to triage still labels Jan 26, 2025

eriqua assigned sebassem Jan 26, 2025

sebassem added 3 commits January 26, 2025 10:31

Merge branch 'Azure:main' into avm-lz-subvending-policy-refresh

e71b9be

fix: remove unnecessary Az.Subscription module import from action.yml

81f2aae

fix: update Bicep generator version and template hashes in main.json

1d18ac9

AlexanderSehr reviewed Jan 26, 2025

View reviewed changes

sebassem added 3 commits January 26, 2025 10:48

fix: comment out Az.Accounts module import in resource removal script

4d8e9c2

add comment for pin down

0467a3e

fix: enable Az.Accounts module import in resource removal script

7f736d7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Update `avm/ptn/lz/sub-vending` -- Bug fixes and improvements #4274

fix: Update `avm/ptn/lz/sub-vending` -- Bug fixes and improvements #4274

sebassem commented Jan 23, 2025 •

edited

Loading

microsoft-github-policy-service bot commented Jan 23, 2025

microsoft-github-policy-service bot commented Jan 23, 2025

AlexanderSehr Jan 24, 2025

sebassem Jan 26, 2025

AlexanderSehr Jan 26, 2025

sebassem Jan 26, 2025

AlexanderSehr Jan 26, 2025

sebassem Jan 26, 2025

fix: Update avm/ptn/lz/sub-vending -- Bug fixes and improvements #4274

Are you sure you want to change the base?

fix: Update avm/ptn/lz/sub-vending -- Bug fixes and improvements #4274

Conversation

sebassem commented Jan 23, 2025 • edited Loading

Description

Pipeline Reference

Type of Change

Checklist

microsoft-github-policy-service bot commented Jan 23, 2025

microsoft-github-policy-service bot commented Jan 23, 2025

AlexanderSehr Jan 24, 2025

Choose a reason for hiding this comment

sebassem Jan 26, 2025

Choose a reason for hiding this comment

AlexanderSehr Jan 26, 2025

Choose a reason for hiding this comment

sebassem Jan 26, 2025

Choose a reason for hiding this comment

AlexanderSehr Jan 26, 2025

Choose a reason for hiding this comment

sebassem Jan 26, 2025

Choose a reason for hiding this comment

fix: Update `avm/ptn/lz/sub-vending` -- Bug fixes and improvements #4274

fix: Update `avm/ptn/lz/sub-vending` -- Bug fixes and improvements #4274

sebassem commented Jan 23, 2025 •

edited

Loading