fix: Update avm/ptn/lz/sub-vending -- Bug fixes and improvements

[sebassem]

Description

• Update modules versions
• Switch to private endpoints for the deployment script instead of service endpoints
• Added PublicnetworkAccess:Disabled to the storage account due to a recent change in policy
• Update CI pipeline to pin Az.Accounts and Az,Subscription modules' versions due to a recent bug
• Update deployment script naming to avoid duplicate names

Pipeline Reference

Pipeline

Type of Change

• Update to CI Environment or utilities (Non-module affecting changes)
• Azure Verified Module updates:
  • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
  • Breaking changes and I have bumped the MAJOR version in version.json.
  • Update to documentation

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• I have run Set-AVMModule locally to generate the supporting module files.
• My corresponding pipelines / checks run clean and green without any errors or warnings

[eriqua]

Thanks @sebassem lgtm. Leaving the final approval to @AlexanderSehr as he added the majority of the comments 🙂

[AlexanderSehr]

Given that @jtracey93 is the co-owner I'll leave that to him 😏 my comments where only a side-effect of our troubleshooting, not the module itself

[eriqua]

@sebassem ready for merge 💪 Meanwhile this pipeline has been enabled to run via OIDC. Once merged let me know if any issue with that

[sebassem]

@sebassem ready for merge 💪 Meanwhile this pipeline has been enabled to run via OIDC. Once merged let me know if any issue with that

Will do thank you

[sebassem]

@sebassem ready for merge 💪 Meanwhile this pipeline has been enabled to run via OIDC. Once merged let me know if any issue with that

Hi @eriqua , I got a failure for one of the tests due to expired token. This one takes a long time to complete so maybe the token expired

Your Azure credentials have not been set up or have expired, please run Connect-AzAccount to set up your Azure credentials.

[eriqua]

@sebassem ready for merge 💪 Meanwhile this pipeline has been enabled to run via OIDC. Once merged let me know if any issue with that

Hi @eriqua , I got a failure for one of the tests due to expired token. This one takes a long time to complete so maybe the token expired

Your Azure credentials have not been set up or have expired, please run Connect-AzAccount to set up your Azure credentials.

Hey @sebassem thanks. This is something we noticed for a few modules, specifically in the removal step. Is rerunning the failed task solving the issue? Just to verify if the issue is persistent or transient. In the former case we can add it back to the OIDC exception list and troubleshoot the issue in the meantime. Let me know your thoughts

[sebassem]

@sebassem ready for merge 💪 Meanwhile this pipeline has been enabled to run via OIDC. Once merged let me know if any issue with that

Hi @eriqua , I got a failure for one of the tests due to expired token. This one takes a long time to complete so maybe the token expired
Your Azure credentials have not been set up or have expired, please run Connect-AzAccount to set up your Azure credentials.

Hey @sebassem thanks. This is something we noticed for a few modules, specifically in the removal step. Is rerunning the failed task solving the issue? Just to verify if the issue is persistent or transient. In the former case we can add it back to the OIDC exception list and troubleshoot the issue in the meantime. Let me know your thoughts

I tested re-running the failed step but got the same error, I think maybe we need to add another login step in the pipeline before the removal to refresh the credentials ?