Skip to content

Implement project configuration system #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

skytin1004
Copy link
Collaborator

Purpose

Description

Related Issue

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

  • Yes
  • No

Type of change

  • Bugfix
  • Feature
  • Code style update (e.g., formatting, local variables)
  • Refactoring (no functional or API changes)
  • Documentation content changes
  • Other... Please describe:

Checklist

Before submitting your pull request, please confirm the following:

  • I have thoroughly tested my changes: I confirm that I have run the code and manually tested all affected areas.
  • All existing tests pass: I have run all tests and confirmed that nothing is broken.
  • I have added new tests (if applicable): I have written tests that cover the new functionality introduced by my code changes.
  • I have followed the Co-op Translators coding conventions: My code adheres to the style guide and coding conventions outlined in the repository.
  • I have documented my changes (if applicable): I have updated the documentation to reflect the changes where necessary.

Additional context

… file exclusion

- Implement centralized configuration management using ProjectConfig class
- Add glob pattern-based file exclusion mechanism using fnmatch
- Integrate pattern-based exclusion in DirectoryManager and TranslationManager
- Apply consistent exclusion rules across all file collection logic
@github-actions github-actions bot added the core Related to any changes in core source files label Jul 15, 2025
- Enhance directory management: Create folders only when needed instead of pre-creating the entire structure
- Fix nested folder issues that occurred after migration
- Change CONFIG_FILENAMES list to a single CONFIG_FILENAME variable for consistency
- Fix config file saving method to properly store migration history
- Remove unnecessary comments and clean up code
@skytin1004 skytin1004 marked this pull request as draft July 15, 2025 07:39
@skytin1004
Copy link
Collaborator Author

After a lot of consideration, we've decided to keep Co-op Translator focused and sharp on its core mission: powering GitHub-based open source documentation translation workflows.

While YAML configuration flexibility is valuable, adding this complexity could dilute the tool's current strength - being simple, reliable, and optimized for the specific needs of open source documentation projects.

We believe Co-op Translator should remain:

  • Focused: Excel at markdown/image translation for OSS github open source docs
  • Simple: Minimal configuration, maximum results
  • Reliable: Battle-tested workflow for GitHub Actions

This allows us to continue improving the core translation quality and GitHub integration rather than expanding into general-purpose configuration management.

Closing this PR to maintain focus on our primary mission. 🚀

@skytin1004 skytin1004 closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to any changes in core source files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant