Skip to content

[accessibility-1217621]: Keyboard focus gets lost on the page which opens after activating "Data Explorer" menu item present under 'Overview' page.#1927

Merged
satya07sb merged 1 commit intomasterfrom
accessibility-1217621
Feb 12, 2025
Merged

[accessibility-1217621]: Keyboard focus gets lost on the page which opens after activating "Data Explorer" menu item present under 'Overview' page.#1927
satya07sb merged 1 commit intomasterfrom
accessibility-1217621

Conversation

@satya07sb
Copy link
Contributor

@satya07sb satya07sb commented Aug 12, 2024

This PR addresses an issue where keyboard focus is lost when navigating to the Data Explorer page from the Overview page in Azure Cosmos DB. The problem was that after activating the "Data Explorer" menu item, the page did not correctly set focus on the expected element, impairing keyboard navigation.

Note: We are Using setTimeout with 0ms ensures that the code runs asynchronously after the current execution context completes. Without it, the code is not working as expected due to JavaScript's synchronous execution model.

Preview this branch

accessibility-1217621.mp4

@satya07sb satya07sb force-pushed the accessibility-1217621 branch from 8b0dfee to e3503d2 Compare August 12, 2024 07:06
@satya07sb satya07sb changed the title [accessibility-1217621]:[Usable - Azure Cosmos DB - Data Explorer]: K… [accessibility-1217621]: Keyboard focus gets lost on the page which opens after activating "Data Explorer" menu item present under 'Overview' page. Aug 12, 2024
@satya07sb satya07sb marked this pull request as ready for review August 12, 2024 09:32
@satya07sb satya07sb requested a review from a team as a code owner August 12, 2024 09:32
@satya07sb satya07sb self-assigned this Aug 12, 2024
@sevoku
Copy link
Contributor

sevoku commented Aug 12, 2024

Is there a specific reason we want to focus the refresh button initially? The first focusable element would rather be the first button in the toolbar. However from usability perspective it'd make more sense to focus the big "New Container" button, users who don't have created any container yet, can just proceed from there and others need only to hit Tab once to reach their data. Thoughts?

@satya07sb
Copy link
Contributor Author

satya07sb commented Aug 12, 2024

Is there a specific reason we want to focus the refresh button initially? The first focusable element would rather be the first button in the toolbar. However from usability perspective it'd make more sense to focus the big "New Container" button, users who don't have created any container yet, can just proceed from there and others need only to hit Tab once to reach their data. Thoughts?

As per your suggestion it will make more sense; However, the ticket specifies that the focus should be on the refresh button when opening the Data Explorer.
Ticket: accessibility-1217621

@jawelton74
Copy link
Collaborator

Is there a specific reason we want to focus the refresh button initially? The first focusable element would rather be the first button in the toolbar. However from usability perspective it'd make more sense to focus the big "New Container" button, users who don't have created any container yet, can just proceed from there and others need only to hit Tab once to reach their data. Thoughts?

As per your suggestion it will make more sense; However, the ticket specifies that the focus should be on the refresh button when opening the Data Explorer. Ticket: accessibility-1217621

I agree with Sevo. Let's seek clarification from the accessibility team.

vchske
vchske previously approved these changes Aug 16, 2024
@satya07sb satya07sb marked this pull request as draft August 22, 2024 10:55
@sevoku
Copy link
Contributor

sevoku commented Jan 31, 2025

There is a new comment that they closed the bug which is unfortunate. Let's just go ahead and focus the "New Container" button as we discussed?

…pens after activating "Data Explorer" menu item present under 'Overview' page.
@satya07sb
Copy link
Contributor Author

satya07sb commented Jan 31, 2025

There is a new comment that they closed the bug which is unfortunate. Let's just go ahead and focus the "New Container" button as we discussed?

Sure @sevoku, I’ve discussed this with the accessibility team, but I haven’t received any feedback from them yet. Let’s go ahead with your suggestion for the "New Container" button, as it looks good from every angle.

@satya07sb satya07sb marked this pull request as ready for review January 31, 2025 09:05
@satya07sb satya07sb merged commit bd592d0 into master Feb 12, 2025
20 checks passed
@satya07sb satya07sb deleted the accessibility-1217621 branch February 12, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants