Skip to content

[Screen reader - Cosmos DB Query Copilot - Query Faster with Copilot>Enable Query Advisor]: Screen reader does not announce the dialog information on invoking 'Clear editor' button. #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

satya07sb
Copy link
Collaborator

@satya07sb satya07sb commented Mar 4, 2025

This PR addresses an accessibility issue in the Cosmos DB Query Copilot, specifically when invoking the 'Clear editor' button. Currently, the screen reader does not announce the dialog information properly when this button is clicked. The changes in this PR ensure that the correct label and sub-label are sent to the modal component, allowing the screen reader to accurately announce the dialog content. This enhancement improves the overall accessibility of the application, providing a better experience for users who rely on assistive technologies.

Preview this branch

Before:
image

After:
image

…ery Faster with Copilot>Enable Query Advisor]: Screen reader does not announce the dialog information on invoking 'Clear editor' button.
@satya07sb satya07sb self-assigned this Mar 4, 2025
@satya07sb satya07sb changed the title [accessibility-3560183]:[Screen reader - Cosmos DB Query Copilot - Qu… needed pr description for [Screen reader - Cosmos DB Query Copilot - Query Faster with Copilot>Enable Query Advisor]: Screen reader does not announce the dialog information on invoking 'Clear editor' button. Mar 4, 2025
@satya07sb satya07sb changed the title needed pr description for [Screen reader - Cosmos DB Query Copilot - Query Faster with Copilot>Enable Query Advisor]: Screen reader does not announce the dialog information on invoking 'Clear editor' button. [Screen reader - Cosmos DB Query Copilot - Query Faster with Copilot>Enable Query Advisor]: Screen reader does not announce the dialog information on invoking 'Clear editor' button. Mar 4, 2025
@satya07sb satya07sb removed their assignment Mar 4, 2025
@satya07sb satya07sb self-assigned this Mar 4, 2025
@satya07sb satya07sb marked this pull request as ready for review March 4, 2025 06:46
@satya07sb satya07sb requested a review from a team as a code owner March 4, 2025 06:46
@satya07sb satya07sb merged commit 9f3236c into master Apr 30, 2025
20 checks passed
@satya07sb satya07sb deleted the accessibility-3560183 branch April 30, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants