Skip to content

Updated Contribution Guidelines #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 13, 2021
Merged

Updated Contribution Guidelines #74

merged 14 commits into from
Dec 13, 2021

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Oct 18, 2021

Summary of the Pull Request

This PR adds details about the steering committee: Members, Responsibilities and Contribution scope.

References

None

PR Checklist

  • CLA signed. If not, go over here and sign the CLA

Validation Steps Performed

No Validation required.

@marvinbuss marvinbuss requested a review from uday31in October 18, 2021 11:40
@marvinbuss marvinbuss self-assigned this Oct 18, 2021
@marvinbuss marvinbuss added committed Committed item documentation Improvements or additions to documentation labels Oct 18, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Oct 18, 2021
@marvinbuss marvinbuss requested a review from krnese October 29, 2021 10:26
@ghost ghost added the review Review required for pull request label Oct 29, 2021
@marvinbuss
Copy link
Collaborator Author

@krnese Do you have some guidance for the committee?
I would like to finalize this in order to be able to roll this out to our other repositories.

@marvinbuss marvinbuss marked this pull request as ready for review November 17, 2021 15:44
@marvinbuss marvinbuss requested a review from a team as a code owner November 17, 2021 15:45
@ghost ghost removed the review Review required for pull request label Nov 19, 2021
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates

@marvinbuss
Copy link
Collaborator Author

Thanks @amanjeetsingh for the review. Changed the sentences as requested.

uday31in
uday31in previously approved these changes Dec 12, 2021
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss requested a review from esbran December 12, 2021 16:00
@ghost ghost added the review Review required for pull request label Dec 12, 2021
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ghost ghost removed the review Review required for pull request label Dec 13, 2021
Copy link
Contributor

@esbran esbran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@marvinbuss marvinbuss merged commit 75d886f into main Dec 13, 2021
@marvinbuss marvinbuss deleted the marvinbuss/committee branch December 13, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committed Committed item documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants