Skip to content

Make Cosmos DB, SQL Pool & Stream Analytics Deployment Optional #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 12, 2021

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Oct 28, 2021

Summary of the Pull Request

This PR will make the deployment of Cosmos DB, Synapse SQL Pool and Stream Analytics optional. Users can select whether these should be enabled as part of the deployment.

References

None

PR Checklist

Validation Steps Performed

See Link and images in comments below.

@marvinbuss marvinbuss changed the title Marvinbuss/cosmos optional Make Cosmos & Stream Analytics Deployment Optional Oct 28, 2021
@marvinbuss marvinbuss self-assigned this Oct 28, 2021
@marvinbuss marvinbuss added committed Committed item enhancement New feature or request labels Oct 28, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Oct 28, 2021
@marvinbuss
Copy link
Collaborator Author

Preview Link

@marvinbuss marvinbuss changed the title Make Cosmos & Stream Analytics Deployment Optional Make Cosmos DB, SQL Pool & Stream Analytics Deployment Optional Oct 28, 2021
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss
Copy link
Collaborator Author

Successful deployment:
image

Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss marked this pull request as ready for review October 29, 2021 07:11
@marvinbuss marvinbuss requested a review from a team as a code owner October 29, 2021 07:11
@ghost ghost added the review Review required for pull request label Oct 29, 2021
@ghost ghost removed the review Review required for pull request label Nov 5, 2021
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes.

@ghost ghost added review Review required for pull request and removed review Review required for pull request labels Nov 7, 2021
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss requested review from esbran and removed request for esbran November 10, 2021 08:27
@ghost ghost added the review Review required for pull request label Nov 10, 2021
@ghost ghost removed the review Review required for pull request label Nov 11, 2021
@marvinbuss marvinbuss merged commit 6cfdc24 into main Nov 12, 2021
@marvinbuss marvinbuss deleted the marvinbuss/cosmos_optional branch November 12, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committed Committed item enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants