Skip to content

Added Data Explorer Pool Deployment #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 15, 2021

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Nov 2, 2021

Summary of the Pull Request

Added conditional Data Explorer Pool Deployment to teh Data Product Streaming. These are available in public preview from today.

References

No references.

PR Checklist

Validation Steps Performed

See Test Deployments below

@marvinbuss marvinbuss added committed Committed item feature Feature Requests labels Nov 2, 2021
@marvinbuss marvinbuss self-assigned this Nov 2, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Nov 2, 2021
@marvinbuss marvinbuss linked an issue Nov 2, 2021 that may be closed by this pull request
1 task
@marvinbuss
Copy link
Collaborator Author

Preview Link

@marvinbuss marvinbuss marked this pull request as ready for review November 3, 2021 10:56
@marvinbuss marvinbuss requested a review from a team as a code owner November 3, 2021 10:56
@ghost ghost added the review Review required for pull request label Nov 3, 2021
@amanjeetsingh
Copy link
Contributor

Currently reviewing this. Thanks!

@ghost ghost removed the review Review required for pull request label Nov 5, 2021
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes; nothing major.

@ghost ghost added the review Review required for pull request label Nov 7, 2021
amanjeetsingh
amanjeetsingh previously approved these changes Nov 8, 2021
@ghost ghost removed the review Review required for pull request label Nov 8, 2021
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost ghost added the review Review required for pull request label Nov 10, 2021
@ghost ghost removed the review Review required for pull request label Nov 11, 2021
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amanjeetsingh
amanjeetsingh previously approved these changes Nov 11, 2021
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss merged commit 09bd40d into main Nov 15, 2021
@marvinbuss marvinbuss deleted the marvinbuss/enable_data_explorer branch November 15, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committed Committed item feature Feature Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Synapse Data Explorer as optional deployment
2 participants