Skip to content

Updated Portal UI based on Feedback #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2021
Merged

Updated Portal UI based on Feedback #85

merged 1 commit into from
Nov 18, 2021

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Nov 18, 2021 •
edited
Loading

Summary of the Pull Request

Updated Portal UI based on Feedback (Azure/data-landing-zone#212).

References

Azure/data-landing-zone#212

PR Checklist

Validation Steps Performed

See comments below. Just the tooltip and descriptions have changes as well as the default option. No major changes!

@marvinbuss marvinbuss added feature Feature Requests committed Committed item labels Nov 18, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Nov 18, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner November 18, 2021 08:53
@marvinbuss marvinbuss self-assigned this Nov 18, 2021
@ghost ghost added the review Review required for pull request label Nov 18, 2021
@marvinbuss
Copy link
Collaborator Author

Preview Link

marvinbuss
marvinbuss commented Nov 18, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost ghost removed the review Review required for pull request label Nov 18, 2021
andrehass
andrehass approved these changes Nov 18, 2021
View reviewed changes
Copy link

@andrehass andrehass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making this change.

@marvinbuss marvinbuss merged commit 661f53e into main Nov 18, 2021
@marvinbuss marvinbuss deleted the marvinbuss/portal_updates branch November 18, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrehass andrehass andrehass approved these changes

Assignees

@marvinbuss marvinbuss

Labels
committed Committed item feature Feature Requests
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinbuss @andrehass