Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update help doc #130

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix: update help doc #130

merged 1 commit into from
Aug 22, 2023

Conversation

JeyJeyGao
Copy link
Collaborator

@JeyJeyGao JeyJeyGao commented Aug 18, 2023

Fix:

  • update the link to plugin-extensibility.md to be v1.0.0

Resolves #128
Signed-off-by: Junjie Gao [email protected]

Signed-off-by: Junjie Gao <[email protected]>
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #130 (84af6d8) into main (a685a90) will decrease coverage by 0.77%.
Report is 1 commits behind head on main.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   94.19%   93.42%   -0.77%     
==========================================
  Files          15       16       +1     
  Lines         465      502      +37     
==========================================
+ Hits          438      469      +31     
- Misses         27       33       +6     
Files Changed Coverage Δ
...ugin.AzureKeyVault/Certificate/CertificateChain.cs 100.00% <ø> (ø)
...on.Plugin.AzureKeyVault/KeyVault/KeyVaultClient.cs 86.20% <53.84%> (-5.80%) ⬇️
...otation.Plugin.AzureKeyVault/Certificate/Pkcs12.cs 100.00% <100.00%> (ø)
Notation.Plugin.AzureKeyVault/Program.cs 76.92% <100.00%> (ø)

Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit cfb47e3 into Azure:main Aug 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document link is not updated.
2 participants