Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add versionless key identifier support #181

Merged
merged 16 commits into from
May 29, 2024
Merged

Conversation

JeyJeyGao
Copy link
Collaborator

@JeyJeyGao JeyJeyGao commented May 27, 2024

Feat:

  • added versionless key/certificate identifier support

Test:

  • added unit test
  • added E2E test

Docs:

  • added tips for versionless id feature
  • fixed NOTE marks

Resolves #180 #178
Signed-off-by: Junjie Gao [email protected]

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.03%. Comparing base (38be1cc) to head (deb8891).

Files Patch % Lines
...on.Plugin.AzureKeyVault/KeyVault/KeyVaultClient.cs 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   91.51%   93.03%   +1.51%     
==========================================
  Files          17       17              
  Lines         601      617      +16     
  Branches       75       78       +3     
==========================================
+ Hits          550      574      +24     
+ Misses         37       31       -6     
+ Partials       14       12       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
docs/ca-signed-workflow.md Outdated Show resolved Hide resolved
docs/self-signed-workflow.md Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Copy link
Collaborator

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit f82c165 into main May 29, 2024
12 checks passed
@JeyJeyGao JeyJeyGao deleted the feat/versionless_cert branch May 29, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support retrieving the latest version of a key or cert without specifying version number
4 participants