Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(test): replace the service principal with federated managed identity to access AKV #212

Closed
wants to merge 16 commits into from

Conversation

JeyJeyGao
Copy link
Collaborator

@JeyJeyGao JeyJeyGao commented Oct 25, 2024

CI:

  • removed service principal.
  • added federated credential with user assigned managed identity.
  • added JS file in ./test/e2e/containerized/get_id_token to obtain the federated token for containerized testing.
  • removed the check for branch source by using Github environment named E2E. The E2E test needs manually approved by the maintainers now.

@JeyJeyGao JeyJeyGao changed the title ci(test): replace service principals with federated managed identity ci(test): replace the service principal with federated managed identity to access AKV Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.03%. Comparing base (501e0e6) to head (3d234e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files          17       17           
  Lines         617      617           
  Branches       78       78           
=======================================
  Hits          574      574           
  Misses         31       31           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant