Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE in CompareRequired #345

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix NRE in CompareRequired #345

merged 1 commit into from
Jul 23, 2024

Conversation

konrad-jamrozik
Copy link

Fixes errors like this one:

image

Command failed: dotnet \"/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.111/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@azure/oad/dlls/OpenApiDiff.dll\" -o /tmp/oad-9EHgIA/old-resolved.json -n /tmp/oad-OSxSXz/new-resolved.json
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at AutoRest.Swagger.Model.Schema.CompareRequired(ComparisonContext`1 context, Schema priorSchema) in D:\\a\\_work\\1\\s\\openapi-diff\\src\\modeler\\AutoRest.Swagger\\Model\\Schema.cs:line 214
   at AutoRest.Swagger.Model.Schema.Compare(ComparisonContext`1 context, Schema previous) in D:\\a\\_work\\1\\s\\openapi-diff\\src\\modeler\\AutoRest.Swagger\\Model\\Schema.cs:line 181
   at AutoRest.Swagger.Model.Schema.CompareProperties(ComparisonContext`1 context, Schema priorSchema) in D:\\a\\_work\\1\\s\\openapi-diff\\src\\modeler\\AutoRest.Swagger\\Model\\Schema.cs:line 270
   at AutoRest.Swagger.Model.Schema.Compare(ComparisonContext`1 context, Schema previous)

@konrad-jamrozik konrad-jamrozik merged commit 8850294 into main Jul 23, 2024
7 checks passed
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/fix_NRe branch July 23, 2024 20:21
@konrad-jamrozik
Copy link
Author

Deployed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants