Skip to content

fix: added null check for isMultipleMRRTsMatchingGivenApp in TokenCacheAccessor which was causing crashes for our users #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: added null check for isMultipleMRRTsMatchingGivenApp in TokenCacheAccessor which was causing crashes for our users #1550

wants to merge 1 commit into from

Conversation

@zeee4real
Copy link

@zeee4real zeee4real commented Jul 30, 2020 •
edited
Loading

  • fix: added null check in method isMultipleMRRTsMatchingGivenApp() of TokenCacheAccessor class which was causing crashes to our users

AdamBJohnsonx added a commit that referenced this pull request Aug 11, 2020
@AdamBJohnsonx
Use newly created nullsage equalsIgnoreCase.
15a76c0 
In reference to #1550

* The only way I can understand the tokenCacheItem to be null is if something mutates the map unsafely.
* Create a nullsafe equalsIgnoreCase utility in common and use it here.
@AdamBJohnsonx AdamBJohnsonx mentioned this pull request Aug 11, 2020
Closed
AdamBJohnsonx added a commit that referenced this pull request Aug 25, 2020
@AdamBJohnsonx
Use newly created nullsage equalsIgnoreCase.
4b71ab0 
In reference to #1550

* The only way I can understand the tokenCacheItem to be null is if something mutates the map unsafely.
* Create a nullsafe equalsIgnoreCase utility in common and use it here.
@ali-suhail ali-suhail mentioned this pull request Oct 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ali-suhail ali-suhail ali-suhail approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeee4real @ali-suhail