Skip to content

Set target sdk and compile sdk to34 #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Set target sdk and compile sdk to34 #1747

wants to merge 8 commits into from

Conversation

@somalaya
Copy link
Contributor

@somalaya somalaya commented Jul 26, 2023 •
edited
Loading

  • Increasing the targetSDK and compileSDK to 34
  • After increasing the targetSDK, it gave some errors like exported attribute must be added when there is an intent filter. So I added that.
  • PowerliftSDK version to the latest '1.0.3' as this one has fixes for target and compile sdk to be 34.

somalaya and others added 4 commits June 9, 2023 11:59
@somalaya
Merging somalaya/release/4.7.1 to release/4.7.1 (#1736)
e26168d 
* updated versions.properties, build.gradle & changeLog

* changed RC1 to RC3 as RC1 and RC2 are already pushed in Jul 2022

* updated common to RC2

* version changed to 4.7.0

* updated to RC3

* removed RC tags

* updated changeLog, version.props and buildGradle
@somalaya
Merge branch 'dev' of https://github.com/AzureAD/azure-activedirector…
72652d2 
…y-library-for-android into dev
@somalaya
Merge branch 'dev' of https://github.com/AzureAD/azure-activedirector…
d30db63 
…y-library-for-android into dev
@somalaya
Merge branch 'dev' of https://github.com/AzureAD/azure-activedirector…
695e934 
…y-library-for-android into dev
@somalaya somalaya requested a review from a team as a code owner July 26, 2023 16:50
@somalaya somalaya changed the title Somalaya/set target sdk and compile sdk to34 Set target sdk and compile sdk to34 Jul 26, 2023
shahzaibj
shahzaibj previously approved these changes Jul 26, 2023
View reviewed changes
p3dr0rv
p3dr0rv previously approved these changes Jul 27, 2023
View reviewed changes
@somalaya somalaya force-pushed the somalaya/setTargetSDKAndCompileSDKTo34 branch from b1da49a to 21ca27f Compare August 4, 2023 18:15
@somalaya somalaya dismissed stale reviews from p3dr0rv and shahzaibj via 21ca27f April 1, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzaibj shahzaibj shahzaibj left review comments

@p3dr0rv p3dr0rv p3dr0rv left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@somalaya @shahzaibj @p3dr0rv