Azure Pipelines Release: Fixing Pool Definitions & Improving Pipeline Inputs #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PRs unfortunately didn't work as expected, as I later found that pool OS needs to be specified at compile time for 1ES PT. As a result, the recommended approach to target multiple OSes in your pipeline is to define your pool configurations as parameters. In doing so, windows and mac builds are able to run.
In addition to making this change, I also moved the definitions of "pre-release" and "version" to be pipeline parameters as opposed to variables. This presents itself better in the UI so that users who trigger the pipeline will be required to provide those inputs.