-
Notifications
You must be signed in to change notification settings - Fork 46
Add device registration broker allowlist, Fixes AB#3491525 #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3491525 to an Azure Boards work item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a device registration broker allowlist by introducing a new method getDeviceRegistrationBrokerAllowlist() in the BrokerData class. The purpose is to create a restricted set of broker apps that are permitted to perform device registration operations, which is a more limited set than the general broker apps.
Changes:
- Added
prodDeviceRegistrationBrokersset that includes the standard production brokers (Microsoft Authenticator, Company Portal, LTW) plus Intune CE - Added
getDeviceRegistrationBrokerAllowlist()method that returns all brokers in debug mode or the restricted production set in release mode - Added
debugIntuneCEto thedebugBrokersset - Minor code formatting improvements (data class parameter alignment, whitespace)
common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerData.kt
Show resolved
Hide resolved
common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerData.kt
Show resolved
Hide resolved
…r device registration
AB#3491525
This pull request updates the
BrokerDataclass and related broker allowlist logic to better support device registration scenarios. The main changes include the addition of a new allowlist for device registration brokers, the inclusion of a new debug broker in the debug allowlist, and some minor formatting improvements.Device Registration Broker Allowlist:
prodDeviceRegistrationBrokers, to explicitly list brokers allowed to perform device registration operations in production.getDeviceRegistrationBrokerAllowlist(), to return the correct device registration broker set depending on whether debug brokers should be trusted.Broker List Updates:
debugIntuneCEto the debug brokers set, ensuring it is recognized in debug scenarios.Code Formatting:
BrokerDatadata class declaration for better readability.