Skip to content

Conversation

@p3dr0rv
Copy link
Contributor

@p3dr0rv p3dr0rv commented Jan 23, 2026

AB#3491525
This pull request updates the BrokerData class and related broker allowlist logic to better support device registration scenarios. The main changes include the addition of a new allowlist for device registration brokers, the inclusion of a new debug broker in the debug allowlist, and some minor formatting improvements.

Device Registration Broker Allowlist:

  • Added a new set, prodDeviceRegistrationBrokers, to explicitly list brokers allowed to perform device registration operations in production.
  • Introduced a new method, getDeviceRegistrationBrokerAllowlist(), to return the correct device registration broker set depending on whether debug brokers should be trusted.

Broker List Updates:

  • Added debugIntuneCE to the debug brokers set, ensuring it is recognized in debug scenarios.

Code Formatting:

  • Improved formatting of the BrokerData data class declaration for better readability.

@p3dr0rv p3dr0rv requested a review from a team as a code owner January 23, 2026 21:16
Copilot AI review requested due to automatic review settings January 23, 2026 21:16
@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@github-actions
Copy link

✅ Work item link check complete. Description contains link AB#3491525 to an Azure Boards work item.

@p3dr0rv p3dr0rv added the No-Changelog This Pull-Request has no associated changelog entry. label Jan 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a device registration broker allowlist by introducing a new method getDeviceRegistrationBrokerAllowlist() in the BrokerData class. The purpose is to create a restricted set of broker apps that are permitted to perform device registration operations, which is a more limited set than the general broker apps.

Changes:

  • Added prodDeviceRegistrationBrokers set that includes the standard production brokers (Microsoft Authenticator, Company Portal, LTW) plus Intune CE
  • Added getDeviceRegistrationBrokerAllowlist() method that returns all brokers in debug mode or the restricted production set in release mode
  • Added debugIntuneCE to the debugBrokers set
  • Minor code formatting improvements (data class parameter alignment, whitespace)

@github-actions github-actions bot changed the title Add device registration broker allowlist Add device registration broker allowlist, Fixes AB#3491525 Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-Changelog This Pull-Request has no associated changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants