Skip to content

Conversation

@mipetriu
Copy link
Contributor

Proposed changes

This PR adds a flag to track when PSSO is registered during the Setup Assistant.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information


#if TARGET_OS_OSX
#if __MAC_OS_X_VERSION_MAX_ALLOWED >= 130000
@property (nonatomic, nullable, strong) ASAuthorizationProviderExtensionLoginManager *loginManager API_AVAILABLE(macos(13.0));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update changelog.txt.

Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new boolean property isSetupAssistantFlow to track when Platform SSO (PSSO) is registered during the macOS Setup Assistant flow. The change is minimal and follows the established pattern for version-gated macOS features.

  • Adds a conditional compilation guard for a future macOS version
  • Introduces a new property following existing naming conventions for PSSO-related flags

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants