Skip to content

Conversation

@juan-arias
Copy link
Member

Proposed changes

This converts the pipeline from one Stage with 3 Jobs to 3 Stages with one Job each, allowing us to re-run a failing stage before waiting (30+ minutes) for the other jobs to finish, for example:
image

now becomes:
image

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

This pull request refactors the Azure Pipelines configuration for validating iOS, Mac, and Vision builds by modularizing the job steps into a reusable template and splitting the validation process into separate pipeline stages for each platform. This improves maintainability and clarity of the pipeline setup.

Key changes:

Pipeline Structure Improvements:

  • The main pipeline YAML (broker_submodule_check.yml) is restructured to define separate stages (Stage_IOS, Stage_MAC, Stage_VISION) for iOS, Mac, and Vision validations, each with its own job and target variable.
  • Each validation job now references a new template file (broker_submodule_steps.yml) for its steps, reducing duplication and making the pipeline easier to update. [1] [2]

Job Step Modularization:

  • All steps required for checking out repositories, updating submodules, setting up dependencies, and running builds/tests are moved into the new broker_submodule_steps.yml template. This includes logic for handling platform-specific requirements like downloading the visionOS SDK.
  • Cleanup and setup steps, including dependency installation and environment configuration, are now consistently handled via the shared template.

Platform-Specific Handling:

  • The process for downloading the visionOS SDK is now encapsulated within the shared template and only runs for the Vision build, improving clarity and reducing unnecessary steps for other platforms.

These changes make the pipeline more modular, easier to maintain, and clearer in its intent for each platform.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the Azure Pipelines configuration for broker submodule validation by converting a single-stage, multi-job pipeline into a multi-stage pipeline with dedicated stages for each platform (iOS, Mac, and Vision). This restructuring allows independent stage re-runs without waiting for all parallel jobs to complete, improving developer efficiency.

Changes:

  • Restructured pipeline from 1 stage with 3 parallel jobs to 3 independent stages with 1 job each
  • Extracted all common build steps into a reusable template file (broker_submodule_steps.yml)
  • Maintained platform-specific logic (e.g., visionOS SDK download) within the shared template using conditional execution

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
azure_pipelines/broker_submodule_check.yml Converted from job matrix to separate stages for iOS, Mac, and Vision validation with platform-specific target variables
azure_pipelines/broker_submodule_steps.yml New template file containing all checkout, dependency setup, build, and cleanup steps shared across all platforms

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Previous timeout value (30m) was in incorrect location so it was using the default of 60 minutes which I'm using now too.
@juan-arias juan-arias enabled auto-merge (squash) January 21, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants