-
Notifications
You must be signed in to change notification settings - Fork 36
Split broker common submodule check into separate stages #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…e stage with 3 jobs to 3 stages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request refactors the Azure Pipelines configuration for broker submodule validation by converting a single-stage, multi-job pipeline into a multi-stage pipeline with dedicated stages for each platform (iOS, Mac, and Vision). This restructuring allows independent stage re-runs without waiting for all parallel jobs to complete, improving developer efficiency.
Changes:
- Restructured pipeline from 1 stage with 3 parallel jobs to 3 independent stages with 1 job each
- Extracted all common build steps into a reusable template file (
broker_submodule_steps.yml) - Maintained platform-specific logic (e.g., visionOS SDK download) within the shared template using conditional execution
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| azure_pipelines/broker_submodule_check.yml | Converted from job matrix to separate stages for iOS, Mac, and Vision validation with platform-specific target variables |
| azure_pipelines/broker_submodule_steps.yml | New template file containing all checkout, dependency setup, build, and cleanup steps shared across all platforms |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Previous timeout value (30m) was in incorrect location so it was using the default of 60 minutes which I'm using now too.
Proposed changes
This converts the pipeline from one Stage with 3 Jobs to 3 Stages with one Job each, allowing us to re-run a failing stage before waiting (30+ minutes) for the other jobs to finish, for example:

now becomes:

Type of change
Risk
Additional information
This pull request refactors the Azure Pipelines configuration for validating iOS, Mac, and Vision builds by modularizing the job steps into a reusable template and splitting the validation process into separate pipeline stages for each platform. This improves maintainability and clarity of the pipeline setup.
Key changes:
Pipeline Structure Improvements:
broker_submodule_check.yml) is restructured to define separate stages (Stage_IOS,Stage_MAC,Stage_VISION) for iOS, Mac, and Vision validations, each with its own job and target variable.broker_submodule_steps.yml) for its steps, reducing duplication and making the pipeline easier to update. [1] [2]Job Step Modularization:
broker_submodule_steps.ymltemplate. This includes logic for handling platform-specific requirements like downloading the visionOS SDK.Platform-Specific Handling:
These changes make the pipeline more modular, easier to maintain, and clearer in its intent for each platform.