Introduce UFIC into api contract #1670
Conversation
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| extern NSString * _Nonnull const MSID_DEVICE_MODEL_KEY;//E.g. iPhone 5S | ||
| extern NSString * _Nonnull const MSID_APP_NAME_KEY; | ||
| extern NSString * _Nonnull const MSID_APP_VER_KEY; | ||
| extern NSString * _Nonnull const MSID_CCS_HINT_KEY; |
There was a problem hiding this comment.
This pull request does not update changelog.txt.
Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.
There was a problem hiding this comment.
Pull request overview
This PR introduces UFIC (User Federated Identity Credential) support into the API contract for OneAuth internal automation testing. The token will be passed through the authentication flow and consumed by ESTS as a form of MFA.
Changes:
- Added
userFederatetedIdentityTokenproperty to MSIDInteractiveTokenRequestParameters - Added constant
MSID_USER_FEDERATED_IDENTITY_CREDENTIAL_KEYfor the header name - Integrated the token into broker operation flow and web view custom headers
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| IdentityCore/src/MSIDConstants.h | Added constant declaration for UFIC header key |
| IdentityCore/src/MSIDConstants.m | Added constant definition for UFIC header value |
| IdentityCore/src/parameters/MSIDInteractiveTokenRequestParameters.h | Added property for user federated identity token |
| IdentityCore/src/broker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.h | Added property to broker operation request |
| IdentityCore/src/broker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m | Added token assignment and JSON serialization |
| IdentityCore/src/requests/MSIDInteractiveAuthorizationCodeRequest.m | Added token to web view custom headers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IdentityCore/src/parameters/MSIDInteractiveTokenRequestParameters.h
Outdated
Show resolved
Hide resolved
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.h
Outdated
Show resolved
Hide resolved
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m
Outdated
Show resolved
Hide resolved
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m
Outdated
Show resolved
Hide resolved
IdentityCore/src/requests/MSIDInteractiveAuthorizationCodeRequest.m
Outdated
Show resolved
Hide resolved
IdentityCore/src/requests/MSIDInteractiveAuthorizationCodeRequest.m
Outdated
Show resolved
Hide resolved
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m
Outdated
Show resolved
Hide resolved
…ps://github.com/AzureAD/microsoft-authentication-library-common-for-objc into maagubuzo/ufic/introduce_ufic_into_api_contract
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m
Show resolved
Hide resolved
|
Can you please do some manual tests to see if the header can be passed in broker request? |
Yes, that logic is within a separate PR. This PR is for you to pass the JWT into common core. In another PR I will accept that value from common core and route from broker to web view headers. |
PR Title Format
Required Format:
[Keyword1] [Keyword2]: Descriptionmajor,minor, orpatch(case-insensitive)feature,bugfix,engg, ortests(case-insensitive)Examples:
[MAJOR] [Feature]: new API[minor] [bugfix]: fix crash[PATCH][tests]:add coverageProposed changes
Describe what this PR is trying to do.
Type of change
Risk
Additional information