[minor][Feature]: Introduce UFIC into API contract#1670
Merged
agubuzomaximus merged 10 commits intodevfrom Jan 30, 2026
Merged
Conversation
added 2 commits
January 21, 2026 13:37
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| @@ -132,6 +132,7 @@ extern NSString * _Nonnull const MSID_APP_VER_KEY; | |||
| extern NSString * _Nonnull const MSID_CCS_HINT_KEY; | |||
There was a problem hiding this comment.
This pull request does not update changelog.txt.
Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces UFIC (User Federated Identity Credential) support into the API contract for OneAuth internal automation testing. The token will be passed through the authentication flow and consumed by ESTS as a form of MFA.
Changes:
- Added
userFederatetedIdentityTokenproperty to MSIDInteractiveTokenRequestParameters - Added constant
MSID_USER_FEDERATED_IDENTITY_CREDENTIAL_KEYfor the header name - Integrated the token into broker operation flow and web view custom headers
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| IdentityCore/src/MSIDConstants.h | Added constant declaration for UFIC header key |
| IdentityCore/src/MSIDConstants.m | Added constant definition for UFIC header value |
| IdentityCore/src/parameters/MSIDInteractiveTokenRequestParameters.h | Added property for user federated identity token |
| IdentityCore/src/broker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.h | Added property to broker operation request |
| IdentityCore/src/broker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m | Added token assignment and JSON serialization |
| IdentityCore/src/requests/MSIDInteractiveAuthorizationCodeRequest.m | Added token to web view custom headers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IdentityCore/src/parameters/MSIDInteractiveTokenRequestParameters.h
Outdated
Show resolved
Hide resolved
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.h
Outdated
Show resolved
Hide resolved
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m
Outdated
Show resolved
Hide resolved
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m
Outdated
Show resolved
Hide resolved
IdentityCore/src/requests/MSIDInteractiveAuthorizationCodeRequest.m
Outdated
Show resolved
Hide resolved
IdentityCore/src/requests/MSIDInteractiveAuthorizationCodeRequest.m
Outdated
Show resolved
Hide resolved
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m
Outdated
Show resolved
Hide resolved
added 2 commits
January 21, 2026 15:20
…ps://github.com/AzureAD/microsoft-authentication-library-common-for-objc into maagubuzo/ufic/introduce_ufic_into_api_contract
antrix1989
approved these changes
Jan 21, 2026
tongyuze
reviewed
Jan 21, 2026
...ker_operation/request/interactive_token_request/MSIDBrokerOperationInteractiveTokenRequest.m
Show resolved
Hide resolved
Contributor
|
Can you please do some manual tests to see if the header can be passed in broker request? |
Contributor
Author
Yes, that logic is within a separate PR. This PR is for you to pass the JWT into common core. In another PR I will accept that value from common core and route from broker to web view headers. |
tongyuze
approved these changes
Jan 22, 2026
ero "exit merge editor" | git merge --continue 2>/dev/null || git log --oneline -3 t branch e branch 'dev' into maagubuzo/ufic/introduce_ufic_into_api_contract
agubuzomaximus
changed the title
antrix1989
approved these changes
Jan 30, 2026
ameyapat
added a commit
that referenced
this pull request
Feb 5, 2026
* dev: (69 commits) [minor][Feature]: Introduce UFIC into API contract (#1670) remove rt from UT (#1675) [minor][Feature]: Add ecs flags to disable pop & claims in browser core. (#1673) [minor][Feature]: Support POP and claims in browser core (#1671) Add new option into MSIDRequestParameters to skip cache on broker response (#1661) CC:Reattah PRT for authorize endpoint after redirect for Mobile Onboarding (#1638) Release/1.19.0 to Dev (#1669) Try to use "Use my password" button after "Other ways to sign in" Add PR title format guidelines Update pr-title-lint.yml Update .github/workflows/pr-title-lint.yml Change PR title lint workflow to use 'dev' branch Add explicit minimal permissions to PR title lint workflow Add PR title lint workflow using centralized validation Initial plan Add CPP exclude macro Add back macro Removing macro Correct case Fixing case ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title Format
Required Format:
[Keyword1] [Keyword2]: Descriptionmajor,minor, orpatch(case-insensitive)feature,bugfix,engg, ortests(case-insensitive)Examples:
[MAJOR] [Feature]: new API[minor] [bugfix]: fix crash[PATCH][tests]:add coverageProposed changes
Describe what this PR is trying to do.
Type of change
Risk
Additional information