Skip to content

Conversation

@antrix1989
Copy link
Contributor

@antrix1989 antrix1989 commented Jan 22, 2026

PR Title Format

Required Format: [Keyword1] [Keyword2]: Description

  • Keyword1: major, minor, or patch (case-insensitive)
  • Keyword2: feature, bugfix, engg, or tests (case-insensitive)

Examples:

  • [MAJOR] [Feature]: new API
  • [minor] [bugfix]: fix crash
  • [PATCH][tests]:add coverage

Proposed changes

Describe what this PR is trying to do.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in the browser native message “GetToken” request parsing for PoP authentication scheme parameters and claims, with accompanying unit tests.

Changes:

  • Parse tokenType + reqCnf from the browser native message request and construct MSIDAuthenticationSchemePop (fallback to Bearer).
  • Parse claims from the request and build an MSIDClaimsRequest.
  • Add unit tests covering claims parsing and PoP/Bearer scheme selection.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
IdentityCore/src/broker_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.m Adds parsing/initialization for PoP auth scheme and claims request.
IdentityCore/src/broker_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.h Exposes new authScheme and claimsRequest properties on the request model.
IdentityCore/tests/MSIDBrowserNativeMessageGetTokenRequestTests.m Adds coverage for claims parsing and PoP/Bearer scheme behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kaisong1990
Copy link
Contributor

@antrix1989 Approved with some comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants