-
Notifications
You must be signed in to change notification settings - Fork 36
[minor][Feature]: Support POP and claims in browser core #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
...r_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds support in the browser native message “GetToken” request parsing for PoP authentication scheme parameters and claims, with accompanying unit tests.
Changes:
- Parse
tokenType+reqCnffrom the browser native message request and constructMSIDAuthenticationSchemePop(fallback to Bearer). - Parse
claimsfrom the request and build anMSIDClaimsRequest. - Add unit tests covering claims parsing and PoP/Bearer scheme selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| IdentityCore/src/broker_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.m | Adds parsing/initialization for PoP auth scheme and claims request. |
| IdentityCore/src/broker_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.h | Exposes new authScheme and claimsRequest properties on the request model. |
| IdentityCore/tests/MSIDBrowserNativeMessageGetTokenRequestTests.m | Adds coverage for claims parsing and PoP/Bearer scheme behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...r_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.m
Outdated
Show resolved
Hide resolved
...r_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.m
Outdated
Show resolved
Hide resolved
IdentityCore/tests/MSIDBrowserNativeMessageGetTokenRequestTests.m
Outdated
Show resolved
Hide resolved
IdentityCore/tests/MSIDBrowserNativeMessageGetTokenRequestTests.m
Outdated
Show resolved
Hide resolved
...r_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.h
Outdated
Show resolved
Hide resolved
...r_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.m
Show resolved
Hide resolved
...r_operation/request/browser_native_message_request/MSIDBrowserNativeMessageGetTokenRequest.m
Show resolved
Hide resolved
|
@antrix1989 Approved with some comments |
PR Title Format
Required Format:
[Keyword1] [Keyword2]: Descriptionmajor,minor, orpatch(case-insensitive)feature,bugfix,engg, ortests(case-insensitive)Examples:
[MAJOR] [Feature]: new API[minor] [bugfix]: fix crash[PATCH][tests]:add coverageProposed changes
Describe what this PR is trying to do.
Type of change
Risk
Additional information