create combined list of tests, did ome manual verification, Fixes AB#3421522 #2432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Work item link check complete. Description contains link AB#3421522 to an Azure Boards work item. |
1 similar comment
|
✅ Work item link check complete. Description contains link AB#3421522 to an Azure Boards work item. |
fadidurah
changed the title
github-actions
bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes test files by moving broker-related update tests from the msalonly package to the broker package, removes several test files, updates test parameterization, and adds a new comprehensive test case documentation file. The changes reduce the overall test count from 115 to 76 (a 34% decrease) by consolidating and removing redundant tests.
Changes:
- Moved three update test classes from
msalonly/updatetobroker/updatepackage - Removed 8 test files (6 from msalonly and 2 from broker packages)
- Updated test parameterization in cross-cloud tests to remove AZURE_US_GOV configuration
- Added comprehensive test case summary documentation
- Updated common subproject commit reference
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TestCaseUpdateLTW.kt | Package declaration updated from msalonly to broker |
| TestCaseUpdateCompanyPortal.kt | Package declaration updated from msalonly to broker |
| TestCaseUpdateAuthenticator.kt | Package declaration updated from msalonly to broker |
| TestCase1420484.java | Removed AZURE_US_GOV from test parameters with TODO comment |
| TestCase99656.java | Deleted entire test file for MFA authentication flow |
| TestCase497044.java | Deleted entire test file for interactive auth with force_login and MFA |
| TestCase497038.java | Deleted entire test file for cross-app SSO with system browser |
| TestCase1561080.java | Deleted entire test file for WPJ device state testing |
| MSALCustomBrokerInstallationTemplateTest.java | Deleted entire template test file |
| TestCase1561185.java | Deleted entire test file for joined PKeyAuth flow |
| TestCase1420494.java | Removed AZURE_US_GOV from test parameters with TODO comment |
| TestCaseSummary_Compact.md | Added new documentation file outlining test consolidation plan |
| common | Updated subproject commit reference |
| mGuestHomeAzureEnvironment = guestHomeAzureEnvironment; | ||
| } | ||
|
|
||
| // TODO US GOV COVERED BY OTHER TESTS, UPDATE ADO ITEM |
There was a problem hiding this comment.
Corrected spelling of 'ome' to 'some' in the PR title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#3421522