Listen on loopback IP addresses #5663
Open
+15
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuth RFCs [8252](https://datatracker.ietf.org/doc/html/rfc8252#section-8.3) and [draft-ietf-oauth-v2-1-14](https://www.ietf.org/archive/id/draft-ietf-oauth-v2-1-14.html#section-8.4.2) say that using "localhost" is not recommended and clients should instead use the loopback IP literals. Added IPv4 and IPv6 IP literals to HttpListener prefixes so that redirect URIs with those literals will not cause errors. Signed-off-by: Niko Lappalainen <niko.lappalainen@m-files.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5662
Changes proposed in this request
DefaultOSBrowser.HttpListenerInterceptoradds loopback IPv4 and IPv6 literals to the HTTP listener prefixes. This ensures that the listener does not respond with an error if redirect URI does not match "localhost".Testing
Performance impact
Documentation