-
Notifications
You must be signed in to change notification settings - Fork 392
Add dSTS integration tests #5669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@XiaoxinMS2 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
- Add 7 comprehensive integration tests for dSTS authority - Tests cover certificate authentication, token caching, tenant switching, correlation ID, and error handling - Store dSTS configuration securely in Key Vault (MISE-dSTS-CustomAppConfig) - Remove hardcoded sensitive information for security - All tests pass successfully (7/7)
a305500 to
f2c6311
Compare
| public const string DefaultAppSecret = "MSAL-App-Default"; | ||
|
|
||
| // dSTS configuration | ||
| public const string AppDsts = "MISE-dSTS-CustomAppConfig"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public const string AppDsts = "MISE-dSTS-CustomAppConfig"; secret name in wrong format. Should be "MISE-App-DSTS-JSON".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your reminder, I would update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, the secret name is stored in KV, and I don't have permission to update the name in KV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyAuld can help you with access to the KV.
Fixes #
Changes proposed in this request
Testing
Performance impact
Documentation